Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove LEDC_HIGH_SPEED_MODE for C3, S2, S3 #2791

Merged
merged 1 commit into from Nov 24, 2021
Merged

Conversation

martgras
Copy link
Contributor

Only ESP32 supports LEDC_HIGH_SPEED_MODE
ESP32-S2, ESP32-C3 and ESP32-S3 don't support it
See https://docs.espressif.com/projects/esp-idf/en/latest/esp32c3/api-reference/peripherals/ledc.html#functionality-overview

What does this implement/fix?

Use highspeed mode only if supported by the chip

Types of changes

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Other

Related issue or feature (if applicable): fixes esphome/issues#2748

Pull request in esphome-docs with documentation (if applicable): esphome/esphome-docs#

Test Environment

  • ESP32
  • ESP32 IDF
  • ESP8266

Example entry for config.yaml:

# Example config.yaml

Checklist:

  • The code change is tested and works locally.
  • Tests have been added to verify that the new code works (under tests/ folder).

If user exposed functionality or configuration variables are added/changed:

@probot-esphome
Copy link

Hey there @OttoWinter, mind taking a look at this pull request as it has been labeled with an integration (ledc) you are listed as a code owner for? Thanks!
(message by CodeOwnersMention)

Copy link
Member

@jesserockz jesserockz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I had almost the same changes in a branch

@jesserockz jesserockz merged commit 4b1d737 into esphome:dev Nov 24, 2021
@github-actions github-actions bot locked and limited conversation to collaborators Nov 26, 2021
@martgras martgras deleted the led-c3 branch January 10, 2022 08:07
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

espidf ledc fails to compile for ESP32C3 board
4 participants