Fixed data type inside fast_random_8() routine

[anatoly-savchenkov]

Fixed data type inside fast_random_8() routine to make the function meaningful

What does this implement/fix?

Testing my previous commits with a static analysis tool I found few obvious issues (and a number of less obvious). I'll try to submit changes addressing obvious defects (and probably issues for questionable but worth looking things) as time allows.

This one fixes data type of an intermediate variable inside fast_random_8() helper routine to make the entire math expression meaningful.

Types of changes

• Bugfix (non-breaking change which fixes an issue)
• New feature (non-breaking change which adds functionality)
• Breaking change (fix or feature that would cause existing functionality to not work as expected)
• Other

Related issue or feature (if applicable): fixes

Pull request in esphome-docs with documentation (if applicable): esphome/esphome-docs#

Test Environment

• ESP32
• ESP32 IDF
• ESP8266

Example entry for config.yaml:

# Example config.yaml

Checklist:

• The code change is tested and works locally.
• Tests have been added to verify that the new code works (under tests/ folder).

If user exposed functionality or configuration variables are added/changed:

• Documentation added/updated in esphome-docs.

[oxan]

Testing my previous commits with a static analysis tool

I'm curious, what tool are you using?