New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor fan platform to resemble climate/cover platforms #2848
Conversation
Co-authored-by: Oxan van Leeuwen <oxan@oxanvanleeuwen.nl>
Hey there @OttoWinter, mind taking a look at this pull request as it has been labeled with an integration ( |
Hey there @esphome/core, mind taking a look at this pull request as it has been labeled with an integration ( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me
What does this implement/fix?
Refactor the
fan
platform to follow the design of theclimate
andcover
platforms, which have better state handling and separation of concerns.The current
FanState
class is left working, but is deprecated, so custom components should keep working.Based on #1370, but rebased and squased to merge in the changes made to the fan model in the meantime.
Types of changes
Related issue or feature (if applicable): fixes
Pull request in esphome-docs with documentation (if applicable): esphome/esphome-docs#
Test Environment
Example entry for
config.yaml
:# Example config.yaml
Checklist:
tests/
folder).If user exposed functionality or configuration variables are added/changed: