Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename post_build scripts to fix codeowners script #3057

Merged
merged 1 commit into from Jan 16, 2022

Conversation

oxan
Copy link
Member

@oxan oxan commented Jan 16, 2022

What does this implement/fix?

Rename the post_build.py scripts introduced in #3003 to not have a .py extension, as they aren't importable outside of PlatformIO. This broke the build_codeowners.py script, generating CI errors.

Types of changes

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Other

Related issue or feature (if applicable): fixes

Pull request in esphome-docs with documentation (if applicable): esphome/esphome-docs#

Test Environment

  • ESP32
  • ESP32 IDF
  • ESP8266

Example entry for config.yaml:

# Example config.yaml

Checklist:

  • The code change is tested and works locally.
  • Tests have been added to verify that the new code works (under tests/ folder).

If user exposed functionality or configuration variables are added/changed:

@probot-esphome
Copy link

Hey there @esphome/core, mind taking a look at this pull request as it has been labeled with an integration (esp32) you are listed as a code owner for? Thanks!
(message by CodeOwnersMention)

@probot-esphome
Copy link

Hey there @esphome/core, mind taking a look at this pull request as it has been labeled with an integration (esp8266) you are listed as a code owner for? Thanks!
(message by CodeOwnersMention)

Copy link
Member

@jesserockz jesserockz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah, Thanks

@jesserockz jesserockz added this to the 2022.1.0b3 milestone Jan 16, 2022
@jesserockz jesserockz merged commit f44fca0 into esphome:dev Jan 16, 2022
@jesserockz jesserockz mentioned this pull request Jan 16, 2022
@github-actions github-actions bot locked and limited conversation to collaborators Jan 18, 2022
@oxan oxan deleted the ci/fix-codeowners branch January 22, 2022 19:08
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants