Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[modbus_controller] add missing skip_updates #3063

Merged
merged 1 commit into from Jan 17, 2022

Conversation

martgras
Copy link
Contributor

What does this implement/fix?

The property `skip_updates' is ignored for modbus switch

Types of changes

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Other

Related issue or feature (if applicable): fixes esphome/issues#2951

Pull request in esphome-docs with documentation (if applicable): esphome/esphome-docs#

Test Environment

  • ESP32
  • ESP32 IDF
  • ESP8266

Checklist:

  • The code change is tested and works locally.
  • Tests have been added to verify that the new code works (under tests/ folder).

If user exposed functionality or configuration variables are added/changed:

@jesserockz jesserockz added this to the 2022.1.0b4 milestone Jan 17, 2022
@jesserockz jesserockz merged commit cdb4fa2 into esphome:dev Jan 17, 2022
@jesserockz jesserockz mentioned this pull request Jan 18, 2022
@martgras martgras deleted the switch-skipupdate branch January 18, 2022 09:43
@jesserockz jesserockz mentioned this pull request Jan 19, 2022
@github-actions github-actions bot locked and limited conversation to collaborators Jan 20, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

MODBUS switch does not skip updates
2 participants