Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix lilygo touchscreen rotation #3221

Merged
merged 1 commit into from Feb 20, 2022
Merged

Fix lilygo touchscreen rotation #3221

merged 1 commit into from Feb 20, 2022

Conversation

jesserockz
Copy link
Member

What does this implement/fix?

I forgot to do the rotation part for lilygo t5 4.7 touchscreens before merging #3084

Types of changes

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Other

Related issue or feature (if applicable): fixes

Pull request in esphome-docs with documentation (if applicable): esphome/esphome-docs#

Test Environment

  • ESP32
  • ESP32 IDF
  • ESP8266

Example entry for config.yaml:

# Example config.yaml

Checklist:

  • The code change is tested and works locally.
  • Tests have been added to verify that the new code works (under tests/ folder).

If user exposed functionality or configuration variables are added/changed:

@jesserockz jesserockz added this to the 2022.2.4 milestone Feb 18, 2022
OttoWinter
OttoWinter approved these changes Feb 18, 2022
View reviewed changes
Copy link
Member

@OttoWinter OttoWinter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@jesserockz jesserockz merged commit 78951c1 into dev Feb 20, 2022
@jesserockz jesserockz deleted the jesserockz-2022-095 branch February 20, 2022 20:58
jesserockz added a commit that referenced this pull request Feb 20, 2022
@jesserockz
Fix lilygo touchscreen rotation (#3221)
e73d479
@jesserockz jesserockz mentioned this pull request Feb 20, 2022
Merged
@github-actions github-actions bot locked and limited conversation to collaborators Feb 22, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@OttoWinter OttoWinter OttoWinter approved these changes

Assignees
No one assigned
Labels
cherry-picked integration: lilygo_t5_47
Projects
None yet
Milestone
2022.2.4
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@jesserockz @OttoWinter