New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix WDT reset during dallas search algorithm #3293
Conversation
Something must be wrong with the family variable (or it's intentionally not used). I can't find any place it's value is read from. We should figure out why it's there in the first place. |
Looking at Maxim's documentation for onewire search at https://www.maximintegrated.com/en/design/technical-documents/app-notes/1/187.html, it seems that |
Thanks! In that case we should just remove the member variable and its assignments |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should have read above comments first...haha
My project stopped because I found this issue: How I can testing patch? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, @wysiwyng !
What does this implement/fix?
Fixes a WDT reset bootloop caused by the dallas sensor search algorithm never terminating for certain combinations of found sensor IDs. This fix was implemented by cross-checking against Paul Stoffregen's OneWire Arduino library.
Types of changes
Related issue or feature (if applicable): fixes esphome/issues#3107
Test Environment
Checklist:
tests/
folder).