Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement media player volume actions #3551

Merged
merged 2 commits into from Jun 13, 2022
Merged

Implement media player volume actions #3551

merged 2 commits into from Jun 13, 2022

Conversation

jesserockz
Copy link
Member

@jesserockz jesserockz commented Jun 12, 2022

What does this implement/fix?

This adds media_player.volume_up / media_player.volume_down / media_player.volume_set actions.

This can be tested with

external_components:
  - source: github://pr#3551
    components: [media_player, i2s_audio]

Types of changes

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Other

Related issue or feature (if applicable): fixes

Pull request in esphome-docs with documentation (if applicable): esphome/esphome-docs#

Test Environment

  • ESP32
  • ESP32 IDF
  • ESP8266

Example entry for config.yaml:

# Example config.yaml

Checklist:

  • The code change is tested and works locally.
  • Tests have been added to verify that the new code works (under tests/ folder).

If user exposed functionality or configuration variables are added/changed:

@jesserockz jesserockz merged commit 8998c5f into dev Jun 13, 2022
@jesserockz jesserockz deleted the jesserockz-2022-196 branch June 13, 2022 01:28
@jesserockz jesserockz mentioned this pull request Jun 13, 2022
@github-actions github-actions bot locked and limited conversation to collaborators Jun 15, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant