New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for V2 of the waveshare 5.83in e-paper display. #3660
Conversation
There hasn't been any activity on this pull request recently. This pull request has been automatically marked as stale because of that and will be closed if no further activity occurs within 7 days. Thank you for your contributions. |
/* | ||
// Reset | ||
this->reset_pin_->digital_write(false); | ||
delay(20); | ||
this->reset_pin_->digital_write(true); | ||
delay(5); | ||
this->reset_pin_->digital_write(false); | ||
delay(20); | ||
*/ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why is this commented out? If it's not needed, then just remove it.
This looks like it would be ready to go, apart from the one change requested by the review. |
Just tested it, works great, thanks @cooki35 |
The changes sound reasonable, I forgot to delete the comments. I removed them. Thanks @ssieb ! |
What does this implement/fix?
Add code to support the WaveShare 5.83in black & white displays with "V2" stickers on them.
The resolution of the V2 version changed (from 600x448) to 648x480.
The init and display code differ from the original 5.83in version.
Types of changes
Related issue or feature (if applicable): fixes esphome/issues#2121
Pull request in esphome-docs with documentation (if applicable): esphome/esphome-docs#2200
Test Environment
The display was connected with the WaveShare e-Paper Driver HAT Rev2.2 and via SPI to an ESP32 (esp32doit-devkit-v1).
The switches of the driver HAT were set to:
Example entry for
config.yaml
:Checklist:
tests/
folder).If user exposed functionality or configuration variables are added/changed: