Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make sprinkler reset_resume() method public #3824

Merged
merged 1 commit into from Sep 20, 2022

Conversation

kbx81
Copy link
Member

@kbx81 kbx81 commented Sep 19, 2022

What does this implement/fix?

Implements esphome/feature-requests#1879

Types of changes

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Other

Related issue or feature (if applicable): fixes esphome/feature-requests#1879

Pull request in esphome-docs with documentation (if applicable): N/A

Test Environment

  • ESP32
  • ESP32 IDF
  • ESP8266

Checklist:

  • The code change is tested and works locally.
  • Tests have been added to verify that the new code works (under tests/ folder).

If user exposed functionality or configuration variables are added/changed:

@jesserockz jesserockz added this to the 2022.9.0b3 milestone Sep 20, 2022
@jesserockz jesserockz merged commit ab8674a into esphome:dev Sep 20, 2022
@jesserockz jesserockz mentioned this pull request Sep 20, 2022
@jesserockz jesserockz mentioned this pull request Sep 21, 2022
@github-actions github-actions bot locked and limited conversation to collaborators Sep 22, 2022
@kbx81 kbx81 deleted the sprinkler-make-reset-resum-public branch January 19, 2023 07:52
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Sprinkler controller - add new public method instead of protected
2 participants