Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for parsing the short local name in the tracker #3854

Merged
merged 3 commits into from Sep 29, 2022

Conversation

bdraco
Copy link
Member

@bdraco bdraco commented Sep 29, 2022

What does this implement/fix?

Fixes missing short local names

Some devices only send a short local name, not a full one. In Home Assistant we can't detect these without the short local name being sent since some integrations only match on local name.

related PR home-assistant/core#79321

Types of changes

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Other

Related issue or feature (if applicable): fixes

Pull request in esphome-docs with documentation (if applicable): esphome/esphome-docs#

Test Environment

  • ESP32
  • ESP32 IDF
  • ESP8266

Example entry for config.yaml:

# Example config.yaml

Checklist:

  • The code change is tested and works locally.
  • Tests have been added to verify that the new code works (under tests/ folder).

If user exposed functionality or configuration variables are added/changed:

ESPHome Dev automation moved this from Needs Review to Reviewer Approved Sep 29, 2022
@jesserockz jesserockz merged commit 106de35 into esphome:dev Sep 29, 2022
ESPHome Dev automation moved this from Reviewer Approved to Done Sep 29, 2022
@github-actions github-actions bot locked and limited conversation to collaborators Oct 1, 2022
ESPHome Dev automation moved this from Done to Reviewer Approved Sep 23, 2023
ESPHome Dev automation moved this from Reviewer Approved to Done Sep 23, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
Development

Successfully merging this pull request may close these issues.

None yet

3 participants