Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

climate: Add features to generic Toshiba model #3912

Merged
merged 1 commit into from Dec 8, 2022

Conversation

zagor
Copy link
Contributor

@zagor zagor commented Oct 16, 2022

What does this implement/fix?

Add fan speed, dry and fan-only operation modes to the "generic" Toshiba climate component.
This reduce differences between generic and PT1411 models.

Types of changes

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Other:

Related issue or feature (if applicable): fixes

Pull request in esphome-docs with documentation (if applicable): esphome/esphome-docs#

Test Environment

  • ESP32
  • ESP32 IDF
  • ESP8266

Example entry for config.yaml:

No configuration change.

Checklist:

  • The code change is tested and works locally.
  • Tests have been added to verify that the new code works (under tests/ folder).

If user exposed functionality or configuration variables are added/changed:

@probot-esphome
Copy link

Hey there @kbx81, mind taking a look at this pull request as it has been labeled with an integration (toshiba) you are listed as a code owner for? Thanks!
(message by CodeOwnersMention)

@zagor zagor force-pushed the add-toshiba-fan-mode branch 2 times, most recently from 647e469 to 664b898 Compare October 16, 2022 16:35
@kbx81
Copy link
Member

kbx81 commented Oct 17, 2022

Does this overlap with #3609?

@zagor
Copy link
Contributor Author

zagor commented Oct 17, 2022

Does this overlap with #3609?

Close, but no. #3609 adds the new quiet fan mode to the climate component only, while my PR only touches the toshiba component. My PR also doesn't implement the quiet fan mode since I chose to not include any custom modes in this first PR.

Once #3609 is merged, adding quiet as a standard fan mode, I can make a new PR implementing it in the toshiba component. (Unless @MichaelMure beats me to it)

I have also considered adding two more custom fan modes to the toshiba component (since it supports five different fan speeds instead of the standard three), but I'm taking things one at a time.

@MichaelMure
Copy link
Contributor

I don't think I'll find time in the upcoming weeks to work on esphome, so if you want to take care of things (including my PRs), please do.

@Dieghito72
Copy link

Dieghito72 commented Nov 29, 2022

This PR and also #3609 is great, is there any plan to merge?

Add fan speed modes, dry and fan-only operation modes.
This reduce differences between generic and PT14111 models.
@zagor
Copy link
Contributor Author

zagor commented Dec 5, 2022

@kbx81 I just rebased this, is there anything else I can help with to get this merged?

Copy link
Member

@kbx81 kbx81 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't have a "generic" Toshiba unit with which to test these specific changes, but the code looks fine to me. 😄

@kbx81 kbx81 merged commit cc45945 into esphome:dev Dec 8, 2022
@github-actions github-actions bot locked and limited conversation to collaborators Dec 10, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants