New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
climate: Add features to generic Toshiba model #3912
Conversation
Hey there @kbx81, mind taking a look at this pull request as it has been labeled with an integration ( |
647e469
to
664b898
Compare
Does this overlap with #3609? |
Close, but no. #3609 adds the new quiet fan mode to the Once #3609 is merged, adding quiet as a standard fan mode, I can make a new PR implementing it in the I have also considered adding two more custom fan modes to the toshiba component (since it supports five different fan speeds instead of the standard three), but I'm taking things one at a time. |
I don't think I'll find time in the upcoming weeks to work on esphome, so if you want to take care of things (including my PRs), please do. |
This PR and also #3609 is great, is there any plan to merge? |
Add fan speed modes, dry and fan-only operation modes. This reduce differences between generic and PT14111 models.
a2d8268
to
8d6eb54
Compare
@kbx81 I just rebased this, is there anything else I can help with to get this merged? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't have a "generic" Toshiba unit with which to test these specific changes, but the code looks fine to me. 😄
What does this implement/fix?
Add fan speed, dry and fan-only operation modes to the "generic" Toshiba climate component.
This reduce differences between generic and PT1411 models.
Types of changes
Related issue or feature (if applicable): fixes
Pull request in esphome-docs with documentation (if applicable): esphome/esphome-docs#
Test Environment
Example entry for
config.yaml
:No configuration change.
Checklist:
tests/
folder).If user exposed functionality or configuration variables are added/changed: