Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for BP1658CJ LED driver #4020

Merged
merged 11 commits into from Dec 22, 2022
Merged

Add support for BP1658CJ LED driver #4020

merged 11 commits into from Dec 22, 2022

Conversation

Cossid
Copy link
Contributor

@Cossid Cossid commented Nov 12, 2022

What does this implement/fix?

This PR adds support for BP1658CJ LED driver as found in the Orein OS0100411267 RGBCT Bulb, LightingInside E12 base candleabra bulb.

Types of changes

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Other

Pull request in esphome-docs with documentation (if applicable): esphome/esphome-docs#2432

Test Environment

  • ESP32
  • ESP32 IDF
  • ESP8266
  • RP2040

Example entry for config.yaml:

    # Example configuration entry
    bp1658cj:
      data_pin: GPIO6
      clock_pin: GPIO7
      max_power_color_channels: 4 # Valid values 0-15
      max_power_white_channels: 6 # Valid values 0-15

    # Individual outputs
    output:
    - platform: bp1658cj
        id: output_red
        channel: 1
    - platform: bp1658cj
        id: output_green
        channel: 2
    - platform: bp1658cj
        id: output_blue
        channel: 0
    - platform: bp1658cj
        id: output_coldwhite
        channel: 3
    - platform: bp1658cj
        id: output_warmwhite
        channel: 4

Checklist:

  • The code change is tested and works locally.
  • Tests have been added to verify that the new code works (under tests/ folder).

If user exposed functionality or configuration variables are added/changed:

@probot-esphome
Copy link

Hey there @Cossid,
Thanks for submitting this pull request! Can you add yourself as a codeowner for this integration? This way we can notify you if a bug report for this integration is reported.
In __init__.py of the integration, please add:

CODEOWNERS = ["@Cossid"]

And run script/build_codeowners.py

(message by NeedsCodeownersLabel)

@Cossid Cossid marked this pull request as ready for review November 12, 2022 18:52
@jesserockz jesserockz merged commit a18ab74 into esphome:dev Dec 22, 2022
@github-actions github-actions bot locked and limited conversation to collaborators Dec 24, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants