Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Roomba IR protocol #4595

Merged
merged 2 commits into from
Apr 24, 2024
Merged

Add Roomba IR protocol #4595

merged 2 commits into from
Apr 24, 2024

Conversation

rforro
Copy link
Contributor

@rforro rforro commented Mar 20, 2023

What does this implement/fix?

Add missing Roomba IR protocol.

Types of changes

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Other

Pull request in esphome-docs with documentation (if applicable): esphome/esphome-docs#2767

Test Environment

  • ESP32
  • ESP32 IDF
  • ESP8266
  • RP2040

Example entry for config.yaml:

esphome:
  name: ir-recv

esp32:
  board: lolin32
  framework:
    type: arduino

# Enable logging
logger:

remote_transmitter:
  pin: GPIO27
  carrier_duty_percent: 50%

remote_receiver:
  pin:
    number: GPIO26
    inverted: true
    mode:
      input: true
      pullup: true
  dump: roomba

Checklist:

  • The code change is tested and works locally.
  • Tests have been added to verify that the new code works (under tests/ folder).

If user exposed functionality or configuration variables are added/changed:

@rforro
Copy link
Contributor Author

rforro commented May 21, 2023

What can I do in order to get it merged?

Copy link
Contributor

@kroimon kroimon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can't check the functionality as I don't have a Roomba, but the code looks good to me 👍

@github-actions
Copy link
Contributor

There hasn't been any activity on this pull request recently. This pull request has been automatically marked as stale because of that and will be closed if no further activity occurs within 7 days. Thank you for your contributions.

@manianac
Copy link

What Roomba models is this compatible with?

Copy link
Contributor

There hasn't been any activity on this pull request recently. This pull request has been automatically marked as stale because of that and will be closed if no further activity occurs within 7 days. Thank you for your contributions.

@github-actions github-actions bot added the stale label Nov 19, 2023
@github-actions github-actions bot closed this Nov 26, 2023
@github-actions github-actions bot locked and limited conversation to collaborators Nov 27, 2023
@nagyrobi nagyrobi added this to the 2024.5.0b1 milestone Apr 18, 2024
@jesserockz jesserockz reopened this Apr 24, 2024
@esphome esphome unlocked this conversation Apr 24, 2024
@codecov-commenter
Copy link

codecov-commenter commented Apr 24, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 53.42%. Comparing base (4d8b5ed) to head (1e45f6c).
Report is 464 commits behind head on dev.

Additional details and impacted files
@@            Coverage Diff             @@
##              dev    #4595      +/-   ##
==========================================
- Coverage   53.70%   53.42%   -0.29%     
==========================================
  Files          50       50              
  Lines        9408     9538     +130     
  Branches     1654     1685      +31     
==========================================
+ Hits         5053     5096      +43     
- Misses       4056     4131      +75     
- Partials      299      311      +12     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jesserockz jesserockz merged commit e2b0d56 into esphome:dev Apr 24, 2024
79 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Apr 26, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants