-
-
Notifications
You must be signed in to change notification settings - Fork 3.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Roomba IR protocol #4595
Add Roomba IR protocol #4595
Conversation
What can I do in order to get it merged? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I can't check the functionality as I don't have a Roomba, but the code looks good to me 👍
There hasn't been any activity on this pull request recently. This pull request has been automatically marked as stale because of that and will be closed if no further activity occurs within 7 days. Thank you for your contributions. |
What Roomba models is this compatible with? |
There hasn't been any activity on this pull request recently. This pull request has been automatically marked as stale because of that and will be closed if no further activity occurs within 7 days. Thank you for your contributions. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## dev #4595 +/- ##
==========================================
- Coverage 53.70% 53.42% -0.29%
==========================================
Files 50 50
Lines 9408 9538 +130
Branches 1654 1685 +31
==========================================
+ Hits 5053 5096 +43
- Misses 4056 4131 +75
- Partials 299 311 +12 ☔ View full report in Codecov by Sentry. |
What does this implement/fix?
Add missing Roomba IR protocol.
Types of changes
Pull request in esphome-docs with documentation (if applicable): esphome/esphome-docs#2767
Test Environment
Example entry for
config.yaml
:Checklist:
tests/
folder).If user exposed functionality or configuration variables are added/changed: