Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

esp32_rmt_led_strip: fix compile with ESP-IDF >= 5 #4856

Merged
merged 2 commits into from May 29, 2023

Conversation

stintel
Copy link
Contributor

@stintel stintel commented May 18, 2023

What does this implement/fix?

Fix compilation of the esp32_rmt_led_strip component with ESP-IDF >= 5.

Types of changes

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Other

Test Environment

  • ESP32
  • ESP32 IDF
  • ESP8266
  • RP2040

Checklist:

  • The code change is tested and works locally.
  • Tests have been added to verify that the new code works (under tests/ folder).

If user exposed functionality or configuration variables are added/changed:

@probot-esphome
Copy link

Hey there @jesserockz, mind taking a look at this pull request as it has been labeled with an integration (esp32_rmt_led_strip) you are listed as a code owner for? Thanks!
(message by CodeOwnersMention)

@kbx81
Copy link
Member

kbx81 commented May 26, 2023

🤔 How did we fix this in https://github.com/esphome/esphome/pull/4364/files ? I remember this issue happening everywhere across the board initially, but I think you changed something so we didn't have to do this fix everywhere else.

@kroimon
Copy link
Contributor

kroimon commented May 26, 2023

@kbx81 It was fixed everywhere else by PR #4671 according to this comment.

@stintel
Copy link
Contributor Author

stintel commented May 26, 2023

The esp32_rmt_led_strip component was added after #4671. Unfortunately there were other components that were also missed in that PR. I have fixed a few more in small PRs hoping they could be reviewed and merged quickly.

@stintel stintel force-pushed the idf5/esp32_rmt_led_strip branch 2 times, most recently from e615804 to c15e3ef Compare May 26, 2023 18:09
@stintel
Copy link
Contributor Author

stintel commented May 27, 2023

Can someone ping me when CI is fixed? Appreciate it!

Signed-off-by: Stijn Tintel <stijn@linux-ipv6.be>
@jesserockz jesserockz merged commit 796b645 into esphome:dev May 29, 2023
25 checks passed
@stintel stintel deleted the idf5/esp32_rmt_led_strip branch May 30, 2023 04:04
@github-actions github-actions bot locked and limited conversation to collaborators Jun 1, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants