Improve BME680 BSEC sensor device classes #4859
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
trvrnrth
changed the title
trvrnrth
commented
May 18, 2023
| state_class=STATE_CLASS_MEASUREMENT, | ||
| ), | ||
| cv.Optional(CONF_BREATH_VOC_EQUIVALENT): sensor.sensor_schema( | ||
| unit_of_measurement=UNIT_PARTS_PER_MILLION, | ||
| icon=ICON_TEST_TUBE, |
There was a problem hiding this comment.
home-assistant/frontend#16576 is required for this to end up with the molecule icon as expected.
There was a problem hiding this comment.
This is now included in the 2023.6.0 HA release.
max246
approved these changes
May 18, 2023
max246
approved these changes
Jun 8, 2023
jesserockz
approved these changes
Jul 9, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this implement/fix?
Uses latest appropriate device classes for all sensors and stops explicitly specifying icons instead allowing the HA frontend to select appropriately.
Types of changes
Related issue or feature (if applicable): fixes
Pull request in esphome-docs with documentation (if applicable): esphome/esphome-docs#
Test Environment
Example entry for
config.yaml:# Example config.yamlChecklist:
tests/folder).If user exposed functionality or configuration variables are added/changed: