Fix esp32_rmt_led_strip color modes #4886
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
probot-esphome
bot
added
integration: esp32_rmt_led_strip
small-pr
by-code-owner
labels
kbx81
approved these changes
May 24, 2023
ssieb
approved these changes
May 24, 2023
Merged
kbx81
pushed a commit
that referenced
this pull request
May 24, 2023
jkl1337
added a commit
to jkl1337/esphome
that referenced
this pull request
Sep 28, 2023
The SHT sensor heater is for special use and defaulting them to on breaks the vast majority of prior configs and seems quite surprising. This appears to have been an inadvertent side effect of PR esphome#5161.
jkl1337
added a commit
to jkl1337/esphome
that referenced
this pull request
Sep 29, 2023
The SHT sensor heater is for special use and defaulting them to on breaks the vast majority of prior configs and seems quite surprising. This appears to have been an inadvertent side effect of PR esphome#5161.
kbx81
pushed a commit
that referenced
this pull request
Sep 29, 2023
clydebarrow
pushed a commit
to clydebarrow/esphome
that referenced
this pull request
Sep 30, 2023
gcormier
pushed a commit
to gcormier/esphome
that referenced
this pull request
Oct 29, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this implement/fix?
Types of changes
Related issue or feature (if applicable): fixes esphome/issues#4536
Pull request in esphome-docs with documentation (if applicable): esphome/esphome-docs#
Test Environment
Example entry for
config.yaml:# Example config.yamlChecklist:
tests/folder).If user exposed functionality or configuration variables are added/changed: