Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

display: add BaseFont and introduce Font::draw methods #4963

Merged
merged 1 commit into from Jun 18, 2023

Conversation

ayufan
Copy link
Contributor

@ayufan ayufan commented Jun 18, 2023

What does this implement/fix?

  • optimise font rendering by about 25%
  • add BaseFont and introduce Font::draw methods
  • move BaseFont, BaseImage and COLOR_* to displaybuffer.h to make image/font only depend on displaybuffer, but not other way around

This does not change the performance of Font.

Types of changes

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change: includes required
  • Other: refactor

Test Environment

  • ESP32
  • ESP32S3
  • ESP32 IDF
  • ESP8266
  • RP2040

Checklist:

  • The code change is tested and works locally.
  • Tests have been added to verify that the new code works (under tests/ folder).

@probot-esphome
Copy link

Hey there @synco, mind taking a look at this pull request as it has been labeled with an integration (graph) you are listed as a code owner for? Thanks!
(message by CodeOwnersMention)

@jesserockz jesserockz merged commit 8c9d63f into esphome:dev Jun 18, 2023
25 checks passed
@ayufan ayufan deleted the display-font-generalize branch June 18, 2023 23:04
@github-actions github-actions bot locked and limited conversation to collaborators Jun 20, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants