Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Apply configured IIR filter setting in generated BMP280 code #4975

Merged
merged 2 commits into from Jun 20, 2023
Merged

Apply configured IIR filter setting in generated BMP280 code #4975

merged 2 commits into from Jun 20, 2023

Conversation

murrayma
Copy link
Contributor

@murrayma murrayma commented Jun 19, 2023

This should match what's done in the similar BME280.

What does this implement/fix?

The Bosch BMP280 and BME280 are very similar parts and both feature an optional IIR filter. This works properly for the BME280, but the configuration options were being silently ignored in the generated code for the BMP280. This corrects that.

Types of changes

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Other

Related issue or feature (if applicable): fixes
esphome/issues#1695

Pull request in esphome-docs with documentation (if applicable): esphome/esphome-docs#

Test Environment

  • ESP32
  • ESP32 IDF
  • ESP8266
  • RP2040

Example entry for config.yaml:

# Example config.yaml

Checklist:

  • The code change is tested and works locally.
  • Tests have been added to verify that the new code works (under tests/ folder).

If user exposed functionality or configuration variables are added/changed:

This should match what's done in the similar BME280.
@jesserockz jesserockz added this to the 2023.6.0b4 milestone Jun 20, 2023
@jesserockz jesserockz merged commit bfe85dd into esphome:dev Jun 20, 2023
25 checks passed
jesserockz pushed a commit that referenced this pull request Jun 21, 2023
Co-authored-by: Martin Murray <murrayma@gmail.com>
@jesserockz jesserockz mentioned this pull request Jun 21, 2023
@jesserockz jesserockz mentioned this pull request Jun 22, 2023
@github-actions github-actions bot locked and limited conversation to collaborators Jun 23, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants