Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix rp2040 pio tool download #4994

Merged
merged 3 commits into from Jun 23, 2023
Merged

Fix rp2040 pio tool download #4994

merged 3 commits into from Jun 23, 2023

Conversation

jesserockz
Copy link
Member

@jesserockz jesserockz commented Jun 22, 2023

What does this implement/fix?

Types of changes

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Other

Related issue or feature (if applicable): fixes esphome/issues#4596

Pull request in esphome-docs with documentation (if applicable): esphome/esphome-docs#

Test Environment

  • ESP32
  • ESP32 IDF
  • ESP8266
  • RP2040

Example entry for config.yaml:

# Example config.yaml
esphome:
  name: rp2040-led

rp2040:
  board: rpipicow
  framework:
    platform_version: https://github.com/maxgerhardt/platform-raspberrypi.git

light:
  - platform: rp2040_pio_led_strip
    chipset: ws2812
    pin: GPIO2
    num_leds: 8
    rgb_order: GRB
    pio: 1
    id: pixels

external_components:
  - source: github://pr#4994
    components: [rp2040, rp2040_pio, rp2040_pio_led_strip]
	refresh: always

Checklist:

  • The code change is tested and works locally.
  • Tests have been added to verify that the new code works (under tests/ folder).

If user exposed functionality or configuration variables are added/changed:

@probot-esphome
Copy link

Hey there @Papa-DMan, mind taking a look at this pull request as it has been labeled with an integration (rp2040_pio_led_strip) you are listed as a code owner for? Thanks!
(message by CodeOwnersMention)

@probot-esphome
Copy link

Hey there @jesserockz,
Thanks for submitting this pull request! Can you add yourself as a codeowner for this integration? This way we can notify you if a bug report for this integration is reported.
In __init__.py of the integration, please add:

CODEOWNERS = ["@jesserockz"]

And run script/build_codeowners.py

(message by NeedsCodeownersLabel)

@jesserockz jesserockz merged commit eb14575 into dev Jun 23, 2023
25 checks passed
@jesserockz jesserockz deleted the jesserockz-2023-238 branch June 23, 2023 04:42
@jesserockz jesserockz mentioned this pull request Jun 23, 2023
jesserockz added a commit that referenced this pull request Jun 23, 2023
@github-actions github-actions bot locked and limited conversation to collaborators Jun 25, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Unable to use rp2040_pio_led_strip building on Linux x86_64
2 participants