Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

display: Rename display.DisplayBufferRef to display.DisplayRef used by lambda #5002

Conversation

ayufan
Copy link
Contributor

@ayufan ayufan commented Jun 25, 2023

What does this implement/fix?

This is a change taken from the #4996.
This requires changes from: #5001.

It is interface breaking change to finish move from display::DisplayBuffer to display::Display:

  • this does change lambda: (for display and pages) to be based on display::Display&
  • this is breaking change for external display components, as they have to change to use displays.DisplayRef

Types of changes

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Other

Test Environment

  • ESP32
  • ESP32S3
  • ESP32 IDF
  • ESP8266
  • RP2040

Checklist:

  • The code change is tested and works locally.
  • Tests have been added to verify that the new code works (under tests/ folder).

@ayufan ayufan force-pushed the display-rename-display-buffer-ref-to-display-ref branch 3 times, most recently from 6936ea8 to 072f321 Compare June 25, 2023 09:11
@ayufan ayufan marked this pull request as draft June 25, 2023 09:14
@ayufan ayufan force-pushed the display-rename-display-buffer-ref-to-display-ref branch 4 times, most recently from 8c3d260 to ee9893b Compare June 26, 2023 13:20
@guillempages guillempages mentioned this pull request Jul 5, 2023
11 tasks
@ayufan ayufan force-pushed the display-rename-display-buffer-ref-to-display-ref branch from ee9893b to 82157b4 Compare July 8, 2023 00:22
@ayufan ayufan marked this pull request as ready for review July 8, 2023 00:25
@kbx81 kbx81 merged commit 98fd092 into esphome:dev Jul 10, 2023
25 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Jul 12, 2023
@ayufan ayufan deleted the display-rename-display-buffer-ref-to-display-ref branch July 12, 2023 08:19
@ayufan ayufan restored the display-rename-display-buffer-ref-to-display-ref branch July 12, 2023 08:19
@ayufan ayufan deleted the display-rename-display-buffer-ref-to-display-ref branch July 12, 2023 08:19
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants