Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adjust signature for on_disconnect #5009

Merged
merged 2 commits into from Jul 4, 2023
Merged

Conversation

bdraco
Copy link
Member

@bdraco bdraco commented Jun 26, 2023

What does this implement/fix?

see esphome/aioesphomeapi#448
esphome/aioesphomeapi@v14.1.1...v15.0.0

Types of changes

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Other

Related issue or feature (if applicable): fixes

Pull request in esphome-docs with documentation (if applicable): esphome/esphome-docs#

Test Environment

  • ESP32
  • ESP32 IDF
  • ESP8266
  • RP2040

Example entry for config.yaml:

# Example config.yaml

Checklist:

  • The code change is tested and works locally.
  • Tests have been added to verify that the new code works (under tests/ folder).

If user exposed functionality or configuration variables are added/changed:

@bdraco bdraco marked this pull request as ready for review June 26, 2023 02:49
@bdraco bdraco requested a review from OttoWinter as a code owner June 26, 2023 02:49
@probot-esphome
Copy link

Hey there @OttoWinter, mind taking a look at this pull request as it has been labeled with an integration (api) you are listed as a code owner for? Thanks!
(message by CodeOwnersMention)

@bdraco bdraco closed this Jun 26, 2023
@bdraco bdraco reopened this Jun 26, 2023
@jesserockz jesserockz merged commit a74abb8 into esphome:dev Jul 4, 2023
45 of 55 checks passed
@bdraco bdraco deleted the on_disconnect branch July 4, 2023 01:07
@github-actions github-actions bot locked and limited conversation to collaborators Jul 6, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants