Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

binary_sensor removed unused filter #5039

Merged
merged 1 commit into from Jul 2, 2023

Conversation

dudanov
Copy link
Contributor

@dudanov dudanov commented Jul 2, 2023

What does this implement/fix?

Removed the unused and essentially unnecessary UniqueFilter. Its function is performed by a deduplicator.

Types of changes

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Other

Test Environment

  • ESP32
  • ESP32 IDF
  • ESP8266
  • RP2040

Checklist:

  • The code change is tested and works locally.
  • Tests have been added to verify that the new code works (under tests/ folder).

If user exposed functionality or configuration variables are added/changed:

@probot-esphome
Copy link

probot-esphome bot commented Jul 2, 2023

Hey there @esphome/core, mind taking a look at this pull request as it has been labeled with an integration (binary_sensor) you are listed as a code owner for? Thanks!
(message by CodeOwnersMention)

@jesserockz jesserockz merged commit cf98c49 into esphome:dev Jul 2, 2023
25 checks passed
rpatel3001 pushed a commit to rpatel3001/esphome that referenced this pull request Jul 3, 2023
@github-actions github-actions bot locked and limited conversation to collaborators Jul 4, 2023
@dudanov dudanov deleted the bsensor-remove-unused-filter branch July 27, 2023 06:51
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants