Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add MCP2515 12MHz xtal support #5089

Merged
merged 3 commits into from Jul 12, 2023
Merged

Add MCP2515 12MHz xtal support #5089

merged 3 commits into from Jul 12, 2023

Conversation

clydebarrow
Copy link
Contributor

@clydebarrow clydebarrow commented Jul 12, 2023

What does this implement/fix?

  • Add support for 12MHz crystal oscillator frequency to MCP2515 driver.
  • Add additional error checks.

Types of changes

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Other

Related issue or feature (if applicable): fixes

Pull request in esphome-docs with documentation (if applicable): esphome/esphome-docs#3055

Test Environment

  • ESP32
  • ESP32 IDF
  • ESP8266
  • RP2040

Example entry for config.yaml:

# Example config.yaml
  - id: can2
    platform: mcp2515
    cs_pin: GPIO13
    clock: 12MHZ
    bit_rate: 500kbps
    can_id: 0x35E

Checklist:

  • The code change is tested and works locally.
  • Tests have been added to verify that the new code works (under tests/ folder).

If user exposed functionality or configuration variables are added/changed:

@probot-esphome
Copy link

Hey there @danielschramm, @mvturnho, mind taking a look at this pull request as it has been labeled with an integration (mcp2515) you are listed as a code owner for? Thanks!
(message by CodeOwnersMention)

@jesserockz jesserockz merged commit ec37dec into esphome:dev Jul 12, 2023
25 checks passed
@danielschramm
Copy link
Contributor

Great work, thanks.

@jesserockz jesserockz mentioned this pull request Jul 12, 2023
@github-actions github-actions bot locked and limited conversation to collaborators Jul 14, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants