Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix use of optional<T> #5091

Merged
merged 1 commit into from Jul 12, 2023
Merged

Fix use of optional<T> #5091

merged 1 commit into from Jul 12, 2023

Conversation

dudanov
Copy link
Contributor

@dudanov dudanov commented Jul 12, 2023

What does this implement/fix?

Fix problem from this conversation https://github.com/esphome/esphome/pull/5038/files#r1260562570

Types of changes

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Other

Test Environment

  • ESP32
  • ESP32 IDF
  • ESP8266
  • RP2040

Checklist:

  • The code change is tested and works locally.
  • Tests have been added to verify that the new code works (under tests/ folder).

If user exposed functionality or configuration variables are added/changed:

@dudanov dudanov changed the title fix Fix use of optional<T> Jul 12, 2023
@jesserockz jesserockz merged commit eb859e8 into esphome:dev Jul 12, 2023
25 checks passed
This was referenced Jul 12, 2023
@github-actions github-actions bot locked and limited conversation to collaborators Jul 14, 2023
@dudanov dudanov deleted the optional-fix branch July 27, 2023 06:52
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants