Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

invert min_rssi check #5150

Merged
merged 2 commits into from Jul 30, 2023
Merged

invert min_rssi check #5150

merged 2 commits into from Jul 30, 2023

Conversation

Jorre05
Copy link
Contributor

@Jorre05 Jorre05 commented Jul 26, 2023 •
edited

What does this implement/fix?

  • Invert the min_rssi check in the ble_presence sensor.
  • reduce the min_rssi minimum value from -90 to -100dB

Types of changes

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Other

Related issue or feature (if applicable): fixes

Pull request in esphome-docs with documentation (if applicable): esphome/esphome-docs#

Test Environment

  • ESP32
  • ESP32 IDF
  • ESP8266
  • RP2040

Example entry for config.yaml:

binary_sensor:
  - platform: ble_presence
    ibeacon_uuid: '83fd0e86-.....'
    min_rssi: -90dB

Checklist:

  • The code change is tested and works locally.
  • Tests have been added to verify that the new code works (under tests/ folder).

If user exposed functionality or configuration variables are added/changed:

@Jorre05 Jorre05 marked this pull request as ready for review July 26, 2023 06:03
nielsnl68
nielsnl68 approved these changes Jul 26, 2023
View reviewed changes
Copy link
Contributor

@nielsnl68 nielsnl68 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good to go

@jesserockz jesserockz added this to the 2023.7.1 milestone Jul 30, 2023
@jesserockz jesserockz merged commit 9a66199 into esphome:dev Jul 30, 2023
25 checks passed
@jesserockz jesserockz mentioned this pull request Aug 1, 2023
Merged
jesserockz pushed a commit that referenced this pull request Aug 1, 2023
@Jorre05 @jesserockz
invert min_rssi check (#5150)
c63cdae
@github-actions github-actions bot locked and limited conversation to collaborators Aug 2, 2023
@Jorre05 Jorre05 deleted the ble_presence_min_rssi_fix branch September 21, 2023 06:13
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@nielsnl68 nielsnl68 nielsnl68 approved these changes

Assignees
No one assigned
Labels
cherry-picked integration: ble_presence small-pr
Projects
None yet
Milestone
2023.7.1
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@Jorre05 @nielsnl68 @jesserockz