Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update "Can't convert" warning to match others in homeassistant_sensor #5162

Merged
merged 1 commit into from Jul 30, 2023

Conversation

PlainTechEnthusiast
Copy link
Contributor

What does this implement/fix?

This change includes the entity_id in warning log messages when the value can't be converted to a number. This matches the inclusion of the entity_id with the other log messages from the component.

Types of changes

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Other

Test Environment

  • ESP32
  • ESP32 IDF
  • ESP8266
  • RP2040

Checklist:

  • The code change is tested and works locally.
  • Tests have been added to verify that the new code works (under tests/ folder).

If user exposed functionality or configuration variables are added/changed:

This change includes the entity_id in warning log messages when the value can't be converted to a number.
This matches the inclusion of the entity_id with the other log messages from the component.
@probot-esphome
Copy link

Hey there @OttoWinter, mind taking a look at this pull request as it has been labeled with an integration (homeassistant) you are listed as a code owner for? Thanks!
(message by CodeOwnersMention)

@jesserockz jesserockz added this to the 2023.7.1 milestone Jul 30, 2023
@jesserockz jesserockz merged commit 9aa5ee3 into esphome:dev Jul 30, 2023
25 checks passed
@jesserockz jesserockz mentioned this pull request Aug 1, 2023
@github-actions github-actions bot locked and limited conversation to collaborators Aug 2, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants