Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add KMeterISO component. #5170

Merged
merged 24 commits into from Aug 8, 2023
Merged

Add KMeterISO component. #5170

merged 24 commits into from Aug 8, 2023

Conversation

Rudd-O
Copy link
Contributor

@Rudd-O Rudd-O commented Jul 31, 2023

What does this implement/fix?

KMeterISO K-Type thermocouple support, pursuant to esphome/feature-requests#2333 .

Types of changes

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Other

Related issue or feature (if applicable): fixes esphome/feature-requests#2333

Pull request in esphome-docs with documentation (if applicable): esphome/esphome-docs#3095

Test Environment

  • ESP32
  • ESP32 IDF
  • ESP8266
  • RP2040

Example entry for config.yaml:

i2c:
  sda: GPIO21
  scl: GPIO22
  scan: true
  id: bus_a
  frequency: 100kHz

sensor:
- platform: kmeteriso
  temperature:
    name: Temperature
  internal_temperature:
    name: Internal temperature
    entity_category: diagnostic

Checklist:

  • The code change is tested and works locally.
  • Tests have been added to verify that the new code works (under tests/ folder).

If user exposed functionality or configuration variables are added/changed:

@Rudd-O
Copy link
Contributor Author

Rudd-O commented Jul 31, 2023

Folks, I need help with the tests and the clang format. Not sure what is going on. Please help me either with pointers or do feel free to add commits to the pull request. Thanks so much in advance!

This is ready for review.

esphome/components/kmeteriso/kmeteriso.cpp Outdated Show resolved Hide resolved
esphome/components/kmeteriso/kmeteriso.cpp Outdated Show resolved Hide resolved
esphome/components/kmeteriso/kmeteriso.cpp Outdated Show resolved Hide resolved
esphome/components/kmeteriso/kmeteriso.cpp Outdated Show resolved Hide resolved
esphome/components/kmeteriso/kmeteriso.h Outdated Show resolved Hide resolved
esphome/components/kmeteriso/kmeteriso.h Outdated Show resolved Hide resolved
esphome/components/kmeteriso/sensor.py Outdated Show resolved Hide resolved
esphome/components/kmeteriso/sensor.py Outdated Show resolved Hide resolved
esphome/components/kmeteriso/sensor.py Outdated Show resolved Hide resolved
Rudd-O and others added 9 commits August 7, 2023 07:50
Co-authored-by: Jesse Hills <3060199+jesserockz@users.noreply.github.com>
Co-authored-by: Jesse Hills <3060199+jesserockz@users.noreply.github.com>
Co-authored-by: Jesse Hills <3060199+jesserockz@users.noreply.github.com>
Co-authored-by: Jesse Hills <3060199+jesserockz@users.noreply.github.com>
Co-authored-by: Jesse Hills <3060199+jesserockz@users.noreply.github.com>
Co-authored-by: Jesse Hills <3060199+jesserockz@users.noreply.github.com>
Co-authored-by: Jesse Hills <3060199+jesserockz@users.noreply.github.com>
@Rudd-O
Copy link
Contributor Author

Rudd-O commented Aug 7, 2023

Thanks for the review. All review suggestions were accepted. PTAL @jesserockz .

@Rudd-O Rudd-O requested a review from jesserockz August 7, 2023 07:57
@Rudd-O
Copy link
Contributor Author

Rudd-O commented Aug 7, 2023

image

Strange. No review comment was unaddressed.

jesserockz
jesserockz previously approved these changes Aug 7, 2023
@jesserockz
Copy link
Member

Thanks for making the changes

@Rudd-O
Copy link
Contributor Author

Rudd-O commented Aug 7, 2023

Despite the approval, I can't merge this — or maybe the UI will allow me to merge once the tests finish. Will wait a little longer.

@jesserockz
Copy link
Member

No, you cannot merge, only people with write access can merge (like myself) which is done when both code and docs are approved

@Rudd-O
Copy link
Contributor Author

Rudd-O commented Aug 7, 2023

No, you cannot merge, only people with write access can merge (like myself) which is done when both code and docs are approved

Cool. Thanks!

@Rudd-O
Copy link
Contributor Author

Rudd-O commented Aug 7, 2023

Check your Discord privmsgs please @jesserockz .

@jesserockz jesserockz merged commit f3329fd into esphome:dev Aug 8, 2023
25 checks passed
@Rudd-O
Copy link
Contributor Author

Rudd-O commented Aug 8, 2023

Woohoo. Thanks.

DrCoolzic pushed a commit to DrCoolzic/esphome that referenced this pull request Aug 9, 2023
Co-authored-by: Jesse Hills <3060199+jesserockz@users.noreply.github.com>
@github-actions github-actions bot locked and limited conversation to collaborators Aug 10, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support for M5Stack KMeterISO
2 participants