New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add KMeterISO component. #5170
Add KMeterISO component. #5170
Conversation
This is ready for review. |
Co-authored-by: Jesse Hills <3060199+jesserockz@users.noreply.github.com>
Co-authored-by: Jesse Hills <3060199+jesserockz@users.noreply.github.com>
Co-authored-by: Jesse Hills <3060199+jesserockz@users.noreply.github.com>
Co-authored-by: Jesse Hills <3060199+jesserockz@users.noreply.github.com>
Co-authored-by: Jesse Hills <3060199+jesserockz@users.noreply.github.com>
Co-authored-by: Jesse Hills <3060199+jesserockz@users.noreply.github.com>
Co-authored-by: Jesse Hills <3060199+jesserockz@users.noreply.github.com>
Thanks for the review. All review suggestions were accepted. PTAL @jesserockz . |
Thanks for making the changes |
Despite the approval, I can't merge this — or maybe the UI will allow me to merge once the tests finish. Will wait a little longer. |
No, you cannot merge, only people with write access can merge (like myself) which is done when both code and docs are approved |
Cool. Thanks! |
Check your Discord privmsgs please @jesserockz . |
Woohoo. Thanks. |
Co-authored-by: Jesse Hills <3060199+jesserockz@users.noreply.github.com>
What does this implement/fix?
KMeterISO K-Type thermocouple support, pursuant to esphome/feature-requests#2333 .
Types of changes
Related issue or feature (if applicable): fixes esphome/feature-requests#2333
Pull request in esphome-docs with documentation (if applicable): esphome/esphome-docs#3095
Test Environment
Example entry for
config.yaml
:Checklist:
tests/
folder).If user exposed functionality or configuration variables are added/changed: