-
-
Notifications
You must be signed in to change notification settings - Fork 3.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Ble client additions and fixes #5277
Conversation
Correct initialise MAC address of BLE client.
fix notify for ble_client
Hey there @buxtronix, mind taking a look at this pull request as it has been labeled with an integration ( |
Hey there @jesserockz, mind taking a look at this pull request as it has been labeled with an integration ( |
Not stale, just waiting for review. |
Still not stale - just old :-) |
Eagerly waiting for this. :) Currently it is not convenient to control Valve Basestations with ESPHome, because when ESPHome is connected, then my PC can not see base stations at all. |
Any chance to get this reviewed? waiting for it... |
What does this implement/fix?
ble_client.connect
andble_client.disconnect
;auto_connect
;play_complex()
andplay_next()
in the new actions, and the existingble_client.ble_write
action so that they can be used sequentially in automation blocks.ble_client
code with particular attention to correct handling of events, especially when multiple actions/triggers are active on the same client.The
ble_client
modules forsensor
,binary_sensor
,switch
and the various triggers have been tested on hardware. Other components for specific hardware that rely on theble_client
component have not been tested by me due to lack of access to that hardware, but compilation has been tested for a selection of these, and a careful code review has been performed to check for potential breaking changes in theBLEClient
class.Types of changes
Related issue or feature (if applicable): fixes esphome/issues#4802
Pull request in esphome-docs with documentation (if applicable): esphome/esphome-docs#3138
Test Environment
Example entry for
config.yaml
:Checklist:
tests/
folder).If user exposed functionality or configuration variables are added/changed: