Resolve offline ESPs in dashboard when using ESPHOME_DASHBOARD_USE_PING=true #5281
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Removed lines 871 and 872 to resolve issue with ESPs offline when using ESPHOME_DASHBOARD_USE_PING=true and mdns.disabled: true
mwolter805
changed the title
Removed blank line below for loop
ssieb
approved these changes
Aug 20, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this implement/fix?
Starting with 2023.7.0 all ESPs with
mdns.disabled: truewere offline in the dashboard on containers usingESPHOME_DASHBOARD_USE_PING=trueeven though they functioned correctly otherwise. Installed 2023.8.1 and the issue was still present.With ssieb's help, found these two lines that appeared to be causing the issue. Removed them on my local container and ESPs using are now correctly found to be online.
Types of changes
Related issue or feature (if applicable): fixes esphome/issues#4732
**Pull request in esphome-docs with documentation (if applicable): no documentation changes necessary
Test Environment
Container
Example entry for
config.yaml:mdns:
disabled: true
Checklist: