New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve dualstack and IPv6 support #5449
Conversation
64b60ab
to
e1d8ecf
Compare
0c9ba99
to
c75906a
Compare
- Defaults to 0, 2 could be a decent number for a connection that needs IPv6 to work.
0644fd4
to
4b757f5
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## dev #5449 +/- ##
==========================================
+ Coverage 53.70% 53.81% +0.10%
==========================================
Files 50 50
Lines 9408 9438 +30
Branches 1654 1660 +6
==========================================
+ Hits 5053 5079 +26
+ Misses 4056 4052 -4
- Partials 299 307 +8 ☔ View full report in Codecov by Sentry. |
Hey there @OttoWinter, mind taking a look at this pull request as it has been labeled with an integration ( |
Libretiny depends on esphome/AsyncTCP#9 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This almost looks good, just a couple of missing things 😉
Fixed! Found an unused variable as well. |
What does this implement/fix?
Makes ESPHome work better with IPv6 by adding a datatype for multiple IP addresses. This adds support for reporting all addresses it got, via
wifi_info
/ethernet_info
text-sensors, via MQTT and as part of debug message.It makes MQTT resolve both IPv6 and IPv4 addresses, and connects over IPv6 (as well as over IPv4 as before).
Breaks external components that assumes ESPHome only has one IP address.
Types of changes
Related issue or feature (if applicable): fixes
esphome/issues#5126
Pull request in esphome-docs with documentation (if applicable): esphome/esphome-docs#3234
Test Environment
Example entry for
config.yaml
:Checklist:
tests/
folder).If user exposed functionality or configuration variables are added/changed: