Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix units for SPS30 number concentration sensors #5452

Merged
merged 1 commit into from Oct 3, 2023

Conversation

kahrendt
Copy link
Contributor

What does this implement/fix?

This PR corrects the units for the number concentration sensors to match the datasheet, page 2. They measure in #/cm³ instead of the current #/m³. I modified the incorrect unit in const.py, as this was the only component using it.

Types of changes

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Other

Related issue or feature (if applicable): fixes esphome/issues#4873

Pull request in esphome-docs with documentation (if applicable): esphome/esphome-docs#3220

Test Environment

  • ESP32
  • ESP32 IDF
  • ESP8266
  • RP2040

Example entry for config.yaml:

# Example config.yaml

Checklist:

  • The code change is tested and works locally.
  • Tests have been added to verify that the new code works (under tests/ folder).

If user exposed functionality or configuration variables are added/changed:

@probot-esphome
Copy link

Hey there @martgras, mind taking a look at this pull request as it has been labeled with an integration (sps30) you are listed as a code owner for? Thanks!
(message by CodeOwnersMention)

@jesserockz jesserockz merged commit 050fa0d into esphome:dev Oct 3, 2023
29 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Oct 5, 2023
@kahrendt kahrendt deleted the fix-sps30-unit branch October 26, 2023 11:48
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Wrong unit for number of particles values from Sensirion SPS30
3 participants