Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Improv BLE component #5518

Merged
merged 7 commits into from
Oct 12, 2023
Merged

Update Improv BLE component #5518

merged 7 commits into from
Oct 12, 2023

Conversation

jesserockz
Copy link
Member

@jesserockz jesserockz commented Oct 12, 2023

What does this implement/fix?

When a BLE service is stopped that was set to advertise in the BLE advertisements, it currently is not removed from the advertisements. This fixes that to remove it from the list.

This also removes AUTO_LOADing of the output and binary sensors.

This PR also includes a small change to the output component to add a new define

Types of changes

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Other

Related issue or feature (if applicable): fixes

Pull request in esphome-docs with documentation (if applicable): esphome/esphome-docs#

Test Environment

  • ESP32
  • ESP32 IDF
  • ESP8266
  • RP2040

Example entry for config.yaml:

# Example config.yaml

Checklist:

  • The code change is tested and works locally.
  • Tests have been added to verify that the new code works (under tests/ folder).

If user exposed functionality or configuration variables are added/changed:

@probot-esphome
Copy link

Hey there @clydebarrow, mind taking a look at this pull request as it has been labeled with an integration (esp32_ble_server) you are listed as a code owner for? Thanks!
(message by CodeOwnersMention)

@probot-esphome
Copy link

Hey there @esphome/core, mind taking a look at this pull request as it has been labeled with an integration (output) you are listed as a code owner for? Thanks!
(message by CodeOwnersMention)

@jesserockz jesserockz changed the title Stop advertising when a ble service is stopped Update Improv BLE component Oct 12, 2023
@jesserockz jesserockz added this to the 2023.10.0b2 milestone Oct 12, 2023
@jesserockz jesserockz merged commit 33ebfd2 into dev Oct 12, 2023
30 checks passed
@jesserockz jesserockz deleted the jesserockz-2023-347 branch October 12, 2023 23:46
jesserockz added a commit that referenced this pull request Oct 13, 2023
@jesserockz jesserockz mentioned this pull request Oct 13, 2023
@github-actions github-actions bot locked and limited conversation to collaborators Oct 15, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants