-
-
Notifications
You must be signed in to change notification settings - Fork 3.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update Improv BLE component #5518
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Hey there @clydebarrow, mind taking a look at this pull request as it has been labeled with an integration ( |
Tidy up and deduplicate status indicator calls Remove auto loading of binary sensor and output
probot-esphome
bot
added
core
integration: esp32_improv
integration: output
and removed
small-pr
labels
Oct 12, 2023
Hey there @esphome/core, mind taking a look at this pull request as it has been labeled with an integration ( |
kbx81
approved these changes
Oct 12, 2023
jesserockz
changed the title
Stop advertising when a ble service is stopped
Update Improv BLE component
Oct 12, 2023
jesserockz
added a commit
that referenced
this pull request
Oct 13, 2023
Merged
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this implement/fix?
When a BLE service is stopped that was set to advertise in the BLE advertisements, it currently is not removed from the advertisements. This fixes that to remove it from the list.
This also removes AUTO_LOADing of the output and binary sensors.
This PR also includes a small change to the
output
component to add a new defineTypes of changes
Related issue or feature (if applicable): fixes
Pull request in esphome-docs with documentation (if applicable): esphome/esphome-docs#
Test Environment
Example entry for
config.yaml
:# Example config.yaml
Checklist:
tests/
folder).If user exposed functionality or configuration variables are added/changed: