Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SM10BIT_BASE - Add delays and ACKs, clear all channels before sleeping. #5526

Merged
merged 2 commits into from
Oct 12, 2023
Merged

SM10BIT_BASE - Add delays and ACKs, clear all channels before sleeping. #5526

merged 2 commits into from
Oct 12, 2023

Conversation

Cossid
Copy link
Contributor

@Cossid Cossid commented Oct 12, 2023

What does this implement/fix?

Add delays and ACKs
Clear all channels before sleeping.

Types of changes

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Other

Test Environment

  • ESP32
  • ESP32 IDF
  • ESP8266
  • RP2040

Checklist:

  • The code change is tested and works locally.
  • Tests have been added to verify that the new code works (under tests/ folder).

If user exposed functionality or configuration variables are added/changed:

@jesserockz jesserockz added this to the 2023.10.0b2 milestone Oct 12, 2023
@jesserockz jesserockz merged commit f5c12b5 into esphome:dev Oct 12, 2023
30 checks passed
jesserockz pushed a commit that referenced this pull request Oct 13, 2023
@Cossid @jesserockz
SM10BIT_BASE - Add delays and ACKs, clear all channels before sleepin…
8c1ad1e 
…g. (#5526)
@jesserockz jesserockz mentioned this pull request Oct 13, 2023
Merged
@github-actions github-actions bot locked and limited conversation to collaborators Oct 15, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@jesserockz jesserockz jesserockz approved these changes

Assignees
No one assigned
Labels
by-code-owner cherry-picked integration: sm10bit_base small-pr
Projects
None yet
Milestone
2023.10.0b2
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@Cossid @jesserockz