Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

esp32_improv advertise capabilities and state in ble service data #5553

Merged
merged 3 commits into from Oct 18, 2023

Conversation

jesserockz
Copy link
Member

What does this implement/fix?

This will advertise the capabilites and state in the service data under UUID 0x4677 (IMPR)

Types of changes

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Other

Related issue or feature (if applicable): fixes

Pull request in esphome-docs with documentation (if applicable): esphome/esphome-docs#

Test Environment

  • ESP32
  • ESP32 IDF
  • ESP8266
  • RP2040

Example entry for config.yaml:

# Example config.yaml

Checklist:

  • The code change is tested and works locally.
  • Tests have been added to verify that the new code works (under tests/ folder).

If user exposed functionality or configuration variables are added/changed:

Copy link
Member

@bdraco bdraco left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@jesserockz jesserockz merged commit 14aa27f into dev Oct 18, 2023
30 checks passed
@jesserockz jesserockz deleted the jesserockz-2023-357 branch October 18, 2023 01:26
@jesserockz jesserockz mentioned this pull request Oct 18, 2023
@jesserockz jesserockz mentioned this pull request Oct 18, 2023
@github-actions github-actions bot locked and limited conversation to collaborators Oct 20, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants