Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow set climate preset to NONE #5588

Merged
merged 1 commit into from Oct 23, 2023

Conversation

dentra
Copy link
Contributor

@dentra dentra commented Oct 23, 2023

What does this implement/fix?

Added the ability to set the climate preset to NONE using a climate call or from MQTT.

Tested on ESP32 IDF, but should work on other platforms as well.

Types of changes

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Other

Related issue or feature (if applicable): fixes

Pull request in esphome-docs with documentation (if applicable): esphome/esphome-docs#

Test Environment

  • ESP32
  • ESP32 IDF
  • ESP8266
  • RP2040

Example entry for config.yaml:

# Example config.yaml

Checklist:

  • The code change is tested and works locally.
  • Tests have been added to verify that the new code works (under tests/ folder).

If user exposed functionality or configuration variables are added/changed:

@probot-esphome
Copy link

Hey there @esphome/core, mind taking a look at this pull request as it has been labeled with an integration (climate) you are listed as a code owner for? Thanks!
(message by CodeOwnersMention)

@dentra dentra changed the title Allow set preset to NONE Allow set climate preset to NONE Oct 23, 2023
@jesserockz jesserockz added this to the 2023.10.2 milestone Oct 23, 2023
@jesserockz jesserockz merged commit b898f75 into esphome:dev Oct 23, 2023
30 checks passed
jesserockz pushed a commit that referenced this pull request Oct 23, 2023
@jesserockz jesserockz mentioned this pull request Oct 23, 2023
@github-actions github-actions bot locked and limited conversation to collaborators Oct 25, 2023
@dentra dentra deleted the climate_set_preset_add_none branch October 28, 2023 20:54
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants