Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add details when error loading package #5603

Merged
merged 1 commit into from
Oct 26, 2023

Conversation

dentra
Copy link
Contributor

@dentra dentra commented Oct 26, 2023

What does this implement/fix?

This PR will add additional information if the package loading fails.

before:

Failed to load packages. yeelight_light_ceil26.yaml is not a valid YAML file. Please check the file contents.

after:

Failed to load packages. yeelight_light_ceil26.yaml is not a valid YAML file. Please check the file contents.
Error reading file config/.esphome/packages/155aacf3/secrets.yaml: [Errno 2] No such file or directory: 'config/.esphome/packages/155aacf3/secrets.yaml'

Types of changes

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Other

Related issue or feature (if applicable): fixes

Pull request in esphome-docs with documentation (if applicable): esphome/esphome-docs#

Test Environment

  • ESP32
  • ESP32 IDF
  • ESP8266
  • RP2040
  • BK72xx
  • RTL87xx

Example entry for config.yaml:

packages:
  ceil26: github://syssi/esphome-yeelight-ceiling-light/yeelight_light_ceil26.yaml

Checklist:

  • The code change is tested and works locally.
  • Tests have been added to verify that the new code works (under tests/ folder).

If user exposed functionality or configuration variables are added/changed:

@jesserockz jesserockz merged commit f6e8d97 into esphome:dev Oct 26, 2023
30 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Oct 28, 2023
@dentra dentra deleted the pkg-error-loading-details branch October 28, 2023 20:51
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants