Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missed ifdefs #5727

Merged
merged 1 commit into from Nov 11, 2023
Merged

Missed ifdefs #5727

merged 1 commit into from Nov 11, 2023

Conversation

descipher
Copy link
Contributor

@descipher descipher commented Nov 10, 2023

What does this implement/fix?

Optionals should not error when undefined

Types of changes

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Other

Related issue or feature (if applicable): fixes

None

Test Environment

  • ESP32
  • ESP32 IDF
  • ESP8266
  • RP2040
  • BK72xx
  • RTL87xx
sensor:
  - platform: ld2420
    moving_distance:
      name : Moving Distance

binary_sensor:
  - platform: ld2420
    has_target:
      name: Presence

select:
  - platform: ld2420
    operating_mode:
      name: Operating Mode

Checklist:

  • The code change is tested and works locally.
  • Tests have been added to verify that the new code works (under tests/ folder).

@kbx81 kbx81 merged commit 6a5cea1 into esphome:dev Nov 11, 2023
44 checks passed
@kbx81 kbx81 added this to the 2023.11.0b4 milestone Nov 11, 2023
@github-actions github-actions bot locked and limited conversation to collaborators Nov 12, 2023
@descipher descipher deleted the component.ld2420.update branch November 17, 2023 01:09
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants