Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support of Honeywell HumidIcon (I2C HIH series) Temperature & Humidity sensor #5730

Merged
merged 14 commits into from
Jan 18, 2024

Conversation

Benichou34
Copy link
Contributor

What does this implement/fix?

Add support of Honeywell HumidIcon (I2C HIH series) Temperature & Humidity sensor

Types of changes

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Other

Related issue or feature: [esphome/feature-requests/issues/1799]

Pull request in esphome-docs with documentation: esphome/esphome-docs#3357

Test Environment

  • ESP32
  • ESP32 IDF
  • ESP8266
  • RP2040
  • BK72xx
  • RTL87xx

Example entry for config.yaml:

sensor:
  - platform: honeywell_hih_i2c
    update_interval: 60s
    temperature:
      name: "Temperature"
    humidity:
      name: "Humidity"

Checklist:

  • The code change is tested and works locally.
  • Tests have been added to verify that the new code works (under tests/ folder).

If user exposed functionality or configuration variables are added/changed:

esphome/components/honeywell_hih_i2c/honeywell_hih.cpp Outdated Show resolved Hide resolved
esphome/components/honeywell_hih_i2c/honeywell_hih.cpp Outdated Show resolved Hide resolved
esphome/components/honeywell_hih_i2c/honeywell_hih.h Outdated Show resolved Hide resolved
esphome/components/honeywell_hih_i2c/honeywell_hih.h Outdated Show resolved Hide resolved
esphome/components/honeywell_hih_i2c/sensor.py Outdated Show resolved Hide resolved
esphome/components/honeywell_hih_i2c/sensor.py Outdated Show resolved Hide resolved
@esphome esphome bot marked this pull request as draft December 22, 2023 06:29
@esphome
Copy link

esphome bot commented Dec 22, 2023

Please take a look at the requested changes, and use the Ready for review button when you are done, thanks 👍

Learn more about our pull request process.

@Benichou34 Benichou34 marked this pull request as ready for review December 26, 2023 18:55
@esphome esphome bot requested a review from jesserockz December 26, 2023 18:55
@codecov-commenter
Copy link

codecov-commenter commented Jan 14, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (8e83c7d) 53.60% compared to head (5bd5e3c) 53.60%.

Additional details and impacted files
@@           Coverage Diff           @@
##              dev    #5730   +/-   ##
=======================================
  Coverage   53.60%   53.60%           
=======================================
  Files          50       50           
  Lines        9374     9374           
  Branches     1650     1650           
=======================================
  Hits         5025     5025           
  Misses       4050     4050           
  Partials      299      299           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jesserockz jesserockz merged commit c9c8d39 into esphome:dev Jan 18, 2024
54 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Jan 20, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants