ESP32-S3 and ESP-IDF don't play well with USB_CDC and need USB_SERIAL_JTAG

[clydebarrow]

instead.

What does this implement/fix?

Fixes compile errors when compiling for ESP-IDF on ESP32-S3 (and probably S2) due to change introduced with
#4853.

Types of changes

• Bugfix (non-breaking change which fixes an issue)
• New feature (non-breaking change which adds functionality)
• Breaking change (fix or feature that would cause existing functionality to not work as expected)
• Other

Related issue or feature (if applicable): fixes

Pull request in esphome-docs with documentation (if applicable): esphome/esphome-docs#

Test Environment

• ESP32
• ESP32 IDF
• ESP8266
• RP2040
• BK72xx
• RTL87xx

Example entry for config.yaml:

# Example config.yaml

Checklist:

• The code change is tested and works locally.
• Tests have been added to verify that the new code works (under tests/ folder).

If user exposed functionality or configuration variables are added/changed:

• Documentation added/updated in esphome-docs.

[probot-esphome]

Hey there @esphome/core, mind taking a look at this pull request as it has been labeled with an integration (logger) you are listed as a code owner for? Thanks!
_{^{(message by CodeOwnersMention)}}

[clydebarrow]

gonna add the C3 as well.

[probot-esphome]

Hey there @esphome/core, mind taking a look at this pull request as it has been labeled with an integration (logger) you are listed as a code owner for? Thanks!
_{^{(message by CodeOwnersMention)}}

[clydebarrow]

Tested on S3, C3 and plain ESP32. Also tested on RP2040.

[clydebarrow]

Arduino on ESP32-C3 is still not right. The current setup results in a default of UART0, which means no output when using the USB_CDC port. If I tweak the config to allow USB_CDC for C3 then it fails at compile time because Serial is not defined by Arduino - it's Serial0. If I replace Serial with Serial0 then another compile error in the platformio main.cpp blocks it. If I work-around that I can get it to build and flash, but then it bootloops :-(

So for now I think it's best left as is and note that USB serial is not supported on the C3 under Arduino.

[kbx81]

Arduino on ESP32-C3 is still not right. The current setup results in a default of UART0, which means no output when using the USB_CDC port. If I tweak the config to allow USB_CDC for C3 then it fails at compile time because Serial is not defined by Arduino - it's Serial0. If I replace Serial with Serial0 then another compile error in the platformio main.cpp blocks it. If I work-around that I can get it to build and flash, but then it bootloops :-(

It behaves this way even with this added? 🤔

[clydebarrow]

It behaves this way even with this added? 🤔

Yes. That works fine with S3, but on C3 Serial (without a 0) is undefined, not only in ESPHome code but also in platformio code. And fixing that leads to the bootloop. I just don't think the Arduino support for the C3 is mature.

/Users/clyde/.platformio/packages/framework-arduinoespressif32@3.20005.220925/cores/esp32/main.cpp: In function 'void app_main()':
/Users/clyde/.platformio/packages/framework-arduinoespressif32@3.20005.220925/cores/esp32/main.cpp:58:5: error: 'Serial' was not declared in this scope
     Serial.begin();
     ^~~~~~

[clydebarrow]

Oh, well this is weird, it's now working with Arduino on C3, with the default as UART0.