Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

esp32_camera: Set framebuffer task prio to 1 #5943

Merged
merged 1 commit into from
Dec 18, 2023

Conversation

gaaf
Copy link
Contributor

@gaaf gaaf commented Dec 15, 2023

What does this implement/fix?

Prio 0 is the lowest possible, competing with the idle task. All non-idle tasks should have a prio > 0. If there's another task at prio > 0 around (like the application's loop task), it is possible the framebuffee task never gets executed.

Perhaps the prio should even be above 1, to keep avoid missing frames.

This came to attention during review of eliminating the delay in the application's main loop in case the loop is already slow (#5869).

Code is untested due to lack of hardware.

Types of changes

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Other

Related issue or feature (if applicable): fixes

Pull request in esphome-docs with documentation (if applicable): esphome/esphome-docs#

Test Environment

  • ESP32
  • ESP32 IDF
  • ESP8266
  • RP2040
  • BK72xx
  • RTL87xx

Checklist:

  • The code change is tested and works locally.
  • Tests have been added to verify that the new code works (under tests/ folder).

If user exposed functionality or configuration variables are added/changed:

Prio 0 is the lowest possible, competing with the idle task. All non-idle
tasks should have a prio > 0. If there's another task at prio > 0  around
(like the application's loop task), it is possible the framebuffere task
never gets executed.

Perhaps the prio should even be above 1, to keep avoid missing frames.
@jesserockz jesserockz added this to the 2023.12.0b3 milestone Dec 18, 2023
@jesserockz jesserockz merged commit 8653972 into esphome:dev Dec 18, 2023
50 checks passed
@jesserockz jesserockz mentioned this pull request Dec 18, 2023
@github-actions github-actions bot locked and limited conversation to collaborators Dec 20, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants