Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix I2CBus::write() bug and add i2c documentation #5947

Merged
merged 4 commits into from
Dec 18, 2023
Merged

Fix I2CBus::write() bug and add i2c documentation #5947

merged 4 commits into from
Dec 18, 2023

Commits on Dec 16, 2023

  1. Fix I2CBus::write() bug add documentation 

    I fixed the length of the buffer incorrectly specified as an uin8_t
to of a size_t.
Added a lot of documentation to the i2c library
Added alias NO_ERROR to ERROR_OK

On branch drcoolzic_fix_i2c
Changes to be committed:
	modified:   esphome/components/i2c/i2c.h
	modified:   esphome/components/i2c/i2c_bus.h
    @DrCoolzic
    DrCoolzic committed Dec 16, 2023
    Configuration menu
    Copy the full SHA
    9787b61 View commit details
    Browse the repository at this point in the history

  2. Fixed lint errors 

    lint does not like slave and bit(s) in comments ?
    @DrCoolzic
    DrCoolzic committed Dec 16, 2023
    Configuration menu
    Copy the full SHA
    1f054e3 View commit details
    Browse the repository at this point in the history

  3. Fixed default arguments on virtual or override 

    methods are prohibited
    @DrCoolzic
    DrCoolzic committed Dec 16, 2023
    Configuration menu
    Copy the full SHA
    5d74f19 View commit details
    Browse the repository at this point in the history

Commits on Dec 18, 2023

  1. Changed length arguments to len for consistency

    @DrCoolzic
    DrCoolzic committed Dec 18, 2023
    Configuration menu
    Copy the full SHA
    f2ac0cd View commit details
    Browse the repository at this point in the history