Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use the correct UART/Serial when CDC is enabled #5957

Merged
merged 1 commit into from
Dec 18, 2023

Conversation

kbx81
Copy link
Member

@kbx81 kbx81 commented Dec 18, 2023

What does this implement/fix?

See discussion on Discord

Types of changes

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Other

Related issue or feature (if applicable): fixes

Pull request in esphome-docs with documentation (if applicable): esphome/esphome-docs#

Test Environment

  • ESP32
  • ESP32 IDF
  • ESP8266
  • RP2040
  • BK72xx
  • RTL87xx

Example entry for config.yaml:

# Example config.yaml

Checklist:

  • The code change is tested and works locally.
  • Tests have been added to verify that the new code works (under tests/ folder).

If user exposed functionality or configuration variables are added/changed:

@probot-esphome
Copy link

Hey there @esphome/core, mind taking a look at this pull request as it has been labeled with an integration (logger) you are listed as a code owner for? Thanks!
(message by CodeOwnersMention)

@jesserockz jesserockz enabled auto-merge (squash) December 18, 2023 07:13
@jesserockz jesserockz added this to the 2023.12.0b3 milestone Dec 18, 2023
@jesserockz jesserockz merged commit d99598b into dev Dec 18, 2023
51 checks passed
@jesserockz jesserockz deleted the fix-uart-with-arduino-cdc branch December 18, 2023 07:33
@jesserockz jesserockz mentioned this pull request Dec 18, 2023
@github-actions github-actions bot locked and limited conversation to collaborators Dec 20, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants