-
-
Notifications
You must be signed in to change notification settings - Fork 3.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for VEML3235 lux sensor #5959
Conversation
Hey there @kbx81, CODEOWNERS = ["@kbx81"] And run (message by NeedsCodeownersLabel) |
e128fb3
to
8021b91
Compare
be2348a
to
bd870ab
Compare
ea4e38d
to
4b06083
Compare
Co-authored-by: Jesse Hills <3060199+jesserockz@users.noreply.github.com>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## dev #5959 +/- ##
=======================================
Coverage 53.69% 53.69%
=======================================
Files 50 50
Lines 9387 9387
Branches 1651 1651
=======================================
Hits 5040 5040
Misses 4048 4048
Partials 299 299 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A few minor things below
Please take a look at the requested changes, and use the Ready for review button when you are done, thanks 👍 |
Co-authored-by: Jesse Hills <3060199+jesserockz@users.noreply.github.com>
Co-authored-by: Jesse Hills <3060199+jesserockz@users.noreply.github.com>
What does this implement/fix?
Add support for VEML3235 lux sensor
Types of changes
Related issue or feature (if applicable): fixes
Pull request in esphome-docs with documentation (if applicable): esphome/esphome-docs#3471
Test Environment
Example entry for
config.yaml
:Checklist:
tests/
folder).If user exposed functionality or configuration variables are added/changed: