Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for VEML3235 lux sensor #5959

Merged
merged 23 commits into from
Jan 17, 2024
Merged

Conversation

kbx81
Copy link
Member

@kbx81 kbx81 commented Dec 18, 2023

What does this implement/fix?

Add support for VEML3235 lux sensor

Types of changes

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Other

Related issue or feature (if applicable): fixes

Pull request in esphome-docs with documentation (if applicable): esphome/esphome-docs#3471

Test Environment

  • ESP32
  • ESP32 IDF
  • ESP8266
  • RP2040
  • BK72xx
  • RTL87xx

Example entry for config.yaml:

# Example config.yaml
sensor:
  - platform: veml3235
    name: Light Sensor
    auto_gain: true
    auto_gain_threshold_high: 0.9
    auto_gain_threshold_low: 0.2
    digital_gain: 1X
    gain: 1X
    integration_time: 50ms

Checklist:

  • The code change is tested and works locally.
  • Tests have been added to verify that the new code works (under tests/ folder).

If user exposed functionality or configuration variables are added/changed:

@probot-esphome
Copy link

Hey there @kbx81,
Thanks for submitting this pull request! Can you add yourself as a codeowner for this integration? This way we can notify you if a bug report for this integration is reported.
In __init__.py of the integration, please add:

CODEOWNERS = ["@kbx81"]

And run script/build_codeowners.py

(message by NeedsCodeownersLabel)

esphome/components/veml3235/sensor.py Outdated Show resolved Hide resolved
esphome/components/veml3235/veml3235.cpp Show resolved Hide resolved
esphome/components/veml3235/veml3235.cpp Outdated Show resolved Hide resolved
esphome/components/veml3235/veml3235.cpp Show resolved Hide resolved
@codecov-commenter
Copy link

codecov-commenter commented Jan 10, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (249cd67) 53.69% compared to head (d340c9f) 53.69%.
Report is 1 commits behind head on dev.

Additional details and impacted files
@@           Coverage Diff           @@
##              dev    #5959   +/-   ##
=======================================
  Coverage   53.69%   53.69%           
=======================================
  Files          50       50           
  Lines        9387     9387           
  Branches     1651     1651           
=======================================
  Hits         5040     5040           
  Misses       4048     4048           
  Partials      299      299           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@jesserockz jesserockz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few minor things below

esphome/components/veml3235/sensor.py Outdated Show resolved Hide resolved
esphome/components/veml3235/sensor.py Outdated Show resolved Hide resolved
esphome/components/veml3235/veml3235.cpp Outdated Show resolved Hide resolved
esphome/components/veml3235/veml3235.cpp Outdated Show resolved Hide resolved
esphome/components/veml3235/veml3235.cpp Outdated Show resolved Hide resolved
@esphome esphome bot marked this pull request as draft January 16, 2024 07:53
@esphome
Copy link

esphome bot commented Jan 16, 2024

Please take a look at the requested changes, and use the Ready for review button when you are done, thanks 👍

Learn more about our pull request process.

kbx81 and others added 3 commits January 16, 2024 02:08
Co-authored-by: Jesse Hills <3060199+jesserockz@users.noreply.github.com>
Co-authored-by: Jesse Hills <3060199+jesserockz@users.noreply.github.com>
@kbx81 kbx81 marked this pull request as ready for review January 16, 2024 08:10
@esphome esphome bot requested a review from jesserockz January 16, 2024 08:10
@jesserockz jesserockz merged commit 0cd232c into esphome:dev Jan 17, 2024
54 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Jan 19, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants