Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rename set_raw_touch_position_ to add_raw_touch_position_ #5962

Merged
merged 1 commit into from
Dec 18, 2023

Conversation

nielsnl68
Copy link
Contributor

What does this implement/fix?

I was not happy with my chosen method name for adding touches to the touch list.

So this PR will rename:

set_raw_touch_position_(); to add_raw_touch_position_();

This is only important for touchscreen driver developers.

Types of changes

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Other

Test Environment

  • ESP32
  • ESP32 IDF
  • ESP8266
  • RP2040
  • BK72xx
  • RTL87xx

Checklist:

  • The code change is tested and works locally.

@probot-esphome
Copy link

Hey there @clydebarrow, mind taking a look at this pull request as it has been labeled with an integration (ft5x06) you are listed as a code owner for? Thanks!
(message by CodeOwnersMention)

@probot-esphome
Copy link

Hey there @gpambrozio, mind taking a look at this pull request as it has been labeled with an integration (ft63x6) you are listed as a code owner for? Thanks!
(message by CodeOwnersMention)

@probot-esphome
Copy link

Hey there @kroimon, mind taking a look at this pull request as it has been labeled with an integration (tt21100) you are listed as a code owner for? Thanks!
(message by CodeOwnersMention)

@probot-esphome
Copy link

Hey there @clydebarrow, @jesserockz, mind taking a look at this pull request as it has been labeled with an integration (gt911) you are listed as a code owner for? Thanks!
(message by CodeOwnersMention)

@probot-esphome
Copy link

Hey there @jesserockz, mind taking a look at this pull request as it has been labeled with an integration (touchscreen) you are listed as a code owner for? Thanks!
(message by CodeOwnersMention)

@clydebarrow clydebarrow merged commit 8961e8a into esphome:dev Dec 18, 2023
58 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Dec 20, 2023
@jesserockz jesserockz added this to the 2023.12.0b5 milestone Dec 20, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants