Add RTTTL volume control.

[nielsnl68]

What does this implement/fix?

Add Gain option to set the volume.

Types of changes

• Bugfix (non-breaking change which fixes an issue)
• New feature (non-breaking change which adds functionality)
• Breaking change (fix or feature that would cause existing functionality to not work as expected)
• Other

Pull request in esphome-docs with documentation (if applicable): esphome/esphome-docs#3644

Test Environment

• ESP32
• ESP32 IDF
• ESP8266
• RP2040
• BK72xx
• RTL87xx

Example

   rtttl:
      speaker: my_speaker
      id: my_rtttl
      gain: 0.8

[probot-esphome]

Hey there @glmnet, mind taking a look at this pull request as it has been labeled with an integration (rtttl) you are listed as a code owner for? Thanks!
_{^{(message by CodeOwnersMention)}}

[jesserockz]

I have not tested this yet, but should this be a config option like volume between 0-10 etc that maps to bigger values?

[nielsnl68]

I have not tested this yet, but should this be a config option like volume between 0-10 etc that maps to bigger values?

Yes, but i need to figure out what the high and low values should be.

[jesserockz]

Yes, but i need to figure out what the high and low values should be.

True...haha

[edwardtfn]

Could this be like a volume_gain argument on the rtttl settings?

Something like:

rtttl:
  output: rtttl_out
  id: my_rtttl
  gain: 2

Or:

rtttl:
  output: rtttl_out
  id: my_rtttl
  gain: 0.5

So you multiply 8192 by the gain, which will be float, with 1 as default or not used and limited by something like 0 to 10 (I haven't tested).

My point is more that naming gain makes more sense than volume in this case.

[nielsnl68]

Could this be like a volume_gain argument on the rtttl settings?

Something like:

rtttl:
  output: rtttl_out
  id: my_rtttl
  gain: 2

Or:

rtttl:
  output: rtttl_out
  id: my_rtttl
  gain: 0.5

So you multiply 8192 by the gain, which will be float, with 1 as default or not used and limited by something like 0 to 10 (I haven't tested).

My point is more that naming gain makes more sense than volume in this case.

I think this is the way to go.

[nielsnl68]

Okay @edwardtfn, @jesserockz i have added the gain option it will be a value between 0.1 to 1. And will be default set to 0.5.

[codecov-commenter]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 53.81%. Comparing base (4d8b5ed) to head (3c281b2).
Report is 30 commits behind head on dev.

Additional details and impacted files

@@            Coverage Diff             @@
##              dev    #5968      +/-   ##
==========================================
+ Coverage   53.70%   53.81%   +0.10%     
==========================================
  Files          50       50              
  Lines        9408     9438      +30     
  Branches     1654     1660       +6     
==========================================
+ Hits         5053     5079      +26     
+ Misses       4056     4052       -4     
- Partials      299      307       +8     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[jesserockz]

A couple of things below, and also can you please update the PR title and description and also add a docs PR for the new config?

Cheers
Jesse

[jesserockz]

Should this log level be reverted?

[nielsnl68]

Thanks for the review @jesserockz. i resolved the issues you reported

[nielsnl68]

A couple of things below, and also can you please update the PR title and description and also add a docs PR for the new config?

Cheers Jesse

I have updated the documentation now.