Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add state listeners to rotary_encoder #6035

Merged
merged 4 commits into from Mar 11, 2024

Conversation

clydebarrow
Copy link
Contributor

What does this implement/fix?

Currently the rotary_encoder component maintains listeners for clockwise and anti-clockwise rotation events; this PR adds
listeners for computed state position changes.

This is intended for use by other components.

Types of changes

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Other

Related issue or feature (if applicable): fixes

Pull request in esphome-docs with documentation (if applicable): esphome/esphome-docs#

Test Environment

  • ESP32
  • ESP32 IDF
  • ESP8266
  • RP2040
  • BK72xx
  • RTL87xx

Example entry for config.yaml:

# Example config.yaml

Checklist:

  • The code change is tested and works locally.
  • Tests have been added to verify that the new code works (under tests/ folder).

If user exposed functionality or configuration variables are added/changed:

@jesserockz
Copy link
Member

It is a sensor, you can just use add_on_state_callback or add_on_raw_state_callback...

@clydebarrow
Copy link
Contributor Author

True, but that uses float so restricts the monotonic values reported to roughly +/- 2^23 after which it will start reporting changes at half the actual rate. While that's a corner case, reporting as int does not have that problem.

@codecov-commenter
Copy link

codecov-commenter commented Jan 16, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (25ab6f0) 53.70% compared to head (93404f4) 53.64%.

Additional details and impacted files
@@            Coverage Diff             @@
##              dev    #6035      +/-   ##
==========================================
- Coverage   53.70%   53.64%   -0.07%     
==========================================
  Files          50       50              
  Lines        9403     9386      -17     
  Branches     1653     1404     -249     
==========================================
- Hits         5050     5035      -15     
  Misses       4055     4055              
+ Partials      298      296       -2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jesserockz jesserockz merged commit dfb14fc into esphome:dev Mar 11, 2024
55 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Mar 13, 2024
@clydebarrow clydebarrow deleted the rotary_encoder branch April 24, 2024 00:21
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants