-
-
Notifications
You must be signed in to change notification settings - Fork 3.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
clang-format and clang-tidy scripts: More robust algorithm to find correct executable #6041
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kbx81
reviewed
Jan 2, 2024
bdraco
reviewed
Jan 2, 2024
bdraco
reviewed
Jan 2, 2024
bdraco
reviewed
Jan 2, 2024
Add to message explaining install process.
bdraco
reviewed
Jan 2, 2024
bdraco
reviewed
Jan 2, 2024
bdraco
reviewed
Jan 2, 2024
bdraco
reviewed
Jan 2, 2024
clean up script exit
bdraco
reviewed
Jan 2, 2024
Looks good. One remaining comment and I think its good to go 👍 |
Looks good. Will test shortly |
bdraco
reviewed
Jan 2, 2024
bdraco
previously approved these changes
Jan 2, 2024
bdraco
reviewed
Jan 3, 2024
kbx81
approved these changes
Jan 3, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested on my M1 MacBook and confirmed working as expected.
Thanks @clydebarrow for working on this and @bdraco for your reviews & input! 🍻
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this implement/fix?
The scripts
script/clang-format
andscript/clang-tidy
don't work well on a Mac with executables installed byhomebrew. This PR checks for either the plain executable name that reports the correct version or a versioned name,
Types of changes
Related issue or feature (if applicable): fixes
Pull request in esphome-docs with documentation (if applicable): esphome/esphome-docs#
Test Environment
Example entry for
config.yaml
:# Example config.yaml
Checklist:
tests/
folder).If user exposed functionality or configuration variables are added/changed: