Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GT911 touchscreen: Fix bug causing touch button release to fail #6042

Merged
merged 2 commits into from
Dec 31, 2023

Conversation

clydebarrow
Copy link
Contributor

@clydebarrow clydebarrow commented Dec 30, 2023

What does this implement/fix?

Recent changes to the touchscreen components introduced a bug in the GT911 that resulted in a release of a touch button (e.g. the red button on an S3BOX-3) to not be notified.

Types of changes

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Other

Related issue or feature (if applicable): fixes

Pull request in esphome-docs with documentation (if applicable): esphome/esphome-docs#

Test Environment

  • ESP32
  • ESP32 IDF
  • ESP8266
  • RP2040
  • BK72xx
  • RTL87xx

Example entry for config.yaml:

# Example config.yaml

Checklist:

  • The code change is tested and works locally.
  • Tests have been added to verify that the new code works (under tests/ folder).

If user exposed functionality or configuration variables are added/changed:

@probot-esphome
Copy link

Hey there @jesserockz, mind taking a look at this pull request as it has been labeled with an integration (gt911) you are listed as a code owner for? Thanks!
(message by CodeOwnersMention)

@clydebarrow clydebarrow changed the title Fix bug causing gt911 touch button release to fail GT911 touchscreen: Fix bug causing touch button release to fail Dec 30, 2023
@kbx81 kbx81 merged commit 773cd0f into esphome:dev Dec 31, 2023
48 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Jan 2, 2024
@clydebarrow clydebarrow deleted the gt911 branch April 24, 2024 00:21
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants