hydreon_rgxx - fix missing cg.add(var.set_model(...)) #6065
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this implement/fix?
cg.add(var.set_model(config[CONF_MODEL])) is omitted from sensor.py, so the configured model (required) is not passed through.
The default model is defined in .h file as RG_9, so RG_9 models are not affected. When RG_15 is configured, the bug is not easily evident because the configuration command for polling mode is the same for RG_9 and RG15. However, the configuration of units as mm and resolution as high is never set for RG_15 as was intended - so the units and resolution are actually currently defined by the DIP switch settings of the RG_15.
Types of changes
Related issue or feature (if applicable): fixes
Pull request in esphome-docs with documentation (if applicable): esphome/esphome-docs#
Test Environment
Example entry for
config.yaml
:# Example config.yaml
Checklist:
tests/
folder).If user exposed functionality or configuration variables are added/changed: